Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip-installability #19

Open
arogozhnikov opened this issue Mar 14, 2024 · 2 comments
Open

Pip-installability #19

arogozhnikov opened this issue Mar 14, 2024 · 2 comments

Comments

@arogozhnikov
Copy link

Hi David,
I've challenged myself to move ANARCI from conda to pip, I've seen you previously have been working on same task in your fork.

you can find result here, currently mimics 2021.02.04, still requires hmmer binary installed
https://github.com/arogozhnikov/microANARCI

It fails AbNumber tests (just as conda version).
Question: why do you think that older version is more correct? Everyone seems to use the latest from conda.

@prihoda
Copy link
Owner

prihoda commented Jun 10, 2024

Hi @arogozhnikov,

I also made some effort to migrate to pyhmmer which enables pure pip install without hmmer dependency, I even created a PR to ANARCI repo but there was no response: oxpig/ANARCI#38

Based on my tests it works, but it would definitely require more testing from their side.

About using version 2020.04.23 - at the time it was due to this bug, not sure if it has been fixed yet: oxpig/ANARCI#17

@arogozhnikov
Copy link
Author

thanks, that's looks like a gross issue for a numbering tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants