-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance join prefilter optimizer #24223
Comments
Can you please give me more details on where exactly we should do this optimization ? |
If I am not wrong it should in the file : |
@kaikalur Can you please guide me through this issue |
Yes you found the code. Basically, right now we do it only if the other side is only a scan+filter+project. So extend it for other cases that I listed above. |
Right @kaikalur I will take it up accordingly . Sorry for this but I might need some help initially. |
Currently we only support it when the other side is scan. We should enhance this feature to:
a) union all of scan
b) if the side has an aggregation on the join key we can still do it (and not do distinct)
c) drop any rows where any of the keys is null (especially important for multi-key joins)
d) make it cost based so that we prefilter the "correct" side which gives best results
CC: @feilong-liu
The text was updated successfully, but these errors were encountered: