Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Have the PUC find the $$PREBID_GLOBAL$$ #168

Open
ethyde opened this issue May 9, 2022 · 7 comments
Open

Feature Request: Have the PUC find the $$PREBID_GLOBAL$$ #168

ethyde opened this issue May 9, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@ethyde
Copy link

ethyde commented May 9, 2022

Hello everyone,

It's not very clear following this issue #51.
How can we customize the $$PREBID_GLOBAL$$ name without having to create a custom build?

@dgirardi
Copy link
Collaborator

dgirardi commented May 9, 2022

When using safeframes there is no dependency on the prebid global. Otherwise, in some situations the creative will try to find and call [global].renderAd(). This, or at least the documentation for this, should be improved.

@ethyde
Copy link
Author

ethyde commented May 13, 2022

Hello,

If I understand well, whatever the namespace of pbjs, UC should be able to find it and use it if necessary?

@pm-harshad-mane
Copy link

pm-harshad-mane commented May 13, 2022

Not sure whether you are looking for this, but changing the name here and building the project will allow you to use another name than pbjs
https://github.com/prebid/prebid-universal-creative/blob/master/package.json#L20
Make sure you are using the same prebid-name-space in PrebidJS too.

@ethyde
Copy link
Author

ethyde commented May 17, 2022

Thanks for yours reply @pm-harshad-mane et @dgirardi :)
So I have to fork or clone this repo to be able to customize the global namespace?

@patmmccann
Copy link

For now yes, but we'll keep this issue open to track identifying the global similar to https://github.com/prebid/Prebid.js/blob/master/src/prebidGlobal.js

@patmmccann patmmccann reopened this May 23, 2022
@patmmccann patmmccann added the enhancement New feature or request label May 23, 2022
@patmmccann patmmccann changed the title Is it possible to custom $$PREBID_GLOBAL$$ without to clone/fork the repo ? Feature Request: Have the PUC find the $$PREBID_GLOBAL$$ Aug 31, 2022
@Hamper
Copy link

Hamper commented Mar 3, 2023

I think that can be usable to implement some parameter for PUC like ucTagData.prebidName = 'pbjs'

@andyblackwell
Copy link

yeah, that method could even support multiple custom prebid instances on a page by passing a key/val along with each unit when setting targeting, like your example, pbjsGlobal = onePbjs on one ad request and pbjsGlobal = twoPbjs on another, PUC could directly know which version a render call needs to be sent to by default, no custom PUC build necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready for Dev
Development

No branches or pull requests

6 participants