-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initializing userid module with config requires manual refresh of ids once config is updated #12104
Comments
That site appears to work as expected for me. Here's some things that might affect user IDs:
|
@dgirardi Thanks for your reply. I'm not sure your screenshot is from 247sports.com as we don't have any of those user ids enabled and we don't have Criteo as a bidder. I'm aware first page load usually doesn't have user ids, but this has been every page load for a while now - I'm just simply not seeing user ids 99% of the time. We have a 500ms auction delay set. I tested out 5000ms and 10000ms and am still not seeing user ids present. We have Optanon consent CMP on all Paramount properties. I thought of that and verified that consent is true (visible in the console logs) so that's not gating this. |
@dgirardi Thanks for your assistance here.
Is there a way to force the processing of the user ids before the bid requests go out? The auctionDelay doesn't seem to do it, but I was hopeful. |
The first call to
If you are adding ids one at a time, you could also refresh each one individually as you go:
You can wait (for an indefinite time) until all IDs have been refreshed before starting auctions:
|
It seems the solution may be to not call setConfig until your loop s over? |
Some options: we could try and issue more prominent documentation about not calling setconfig in a loop like this, or initializing setConfig and then later not calling refresh, we could autorefresh ids after a short delay if config changes and the refresh is not called, or we could add autorefresh on config change to prebid 10. |
@dgirardi How are you monitoring the calls to @patmmccann Thanks for the suggestions and ideas for future-proofing. I've tried calling |
Actually - the above is with Firefox. With chrome the first call has all (or maybe some?) of the IDs: That is not the case on 247sports: I think this might be a race condition - 247sports is a much heavier website, and it's possible that the configuration logic runs in a different order (also affected by the browser). |
Agreed that this seems like some sort of race condition. CBS Sports is a heavy site as well, but user ids are usually present in the bid requests there, might be a better means of comparison. I'm wondering if consent is hanging things up on 247 Sports - it's initially set to false until we process Optanon data and then we trigger the setting of the user ids when consent is true. It seems like this is perhaps happening after the bid requests have already gone out on 247... |
Committee discussion result: we should add the auto-id-refresh-on-config-change feature behind a flag, and make it default in 10. |
Proposal:
|
Type of issue
bug
Description
User ids are not present in bid requests on 247sports.com most of the time. I am seeing the user ids present in the bid requests very infrequently, like every few days for one or two page reloads. This is working as expected 100% of the time on some of our other properties (comicbook.com, insideedition.com, cbssports.com for example) with the same implementation. The user ids are present in the userSync config (
pbjs.getConfig().userSync.userIds
), but not in the Prebid userIds object (pbjs.getUserIds()
).Steps to reproduce
userId
object is not presentpbjs.getConfig().userSync.userIds
in the console to see that the userSync config is set properlypbjs.getUserIds()
to see an empty prebid userIds objectExpected results
If the
userSync.userIds
config is set, there should be auserId
object in the bid requests and runningpbjs.getUserIds()
should produce a non-empty object.Actual results
There is no
userId
object in the bid requests.The text was updated successfully, but these errors were encountered: