Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: adding and tracking refresh depth param #12083

Closed
mkendall07 opened this issue Aug 2, 2024 · 6 comments
Closed

feature: adding and tracking refresh depth param #12083

mkendall07 opened this issue Aug 2, 2024 · 6 comments

Comments

@mkendall07
Copy link
Member

mkendall07 commented Aug 2, 2024

Type of issue

Feature request

Description

ORTB has a standard refresh parameter that defines the refresh depth (https://github.com/InteractiveAdvertisingBureau/openrtb2.x/blob/main/2.6.md#objectrefresh). Would prebid.js be able to keep track and increment this based on the calls to requestBids ? Seems like something that would be useful vs having the pub try and configure it properly with each call.

@patmmccann
Copy link
Collaborator

patmmccann commented Aug 4, 2024

You linked the develop branch, also what's wrong with

loop: bid.bidderRequestsCount || 0,

@mkendall07
Copy link
Member Author

You linked the develop branch

Fixed the link thanks. bid.bidderRequestsCount seems to be holding the same information as refresh.count which is great, but there are additional fields inside refresh.refsettings that could be interesting to set such as the reftype and minint.

Would it make sense for the ORTB2 converter to pick this up at least from bid.bidderRequestCount and merge with (if any) settings on the imp ORTB2 setting?

@patmmccann
Copy link
Collaborator

patmmccann commented Aug 5, 2024

Hmmm, the refresh proposal is rather publisher unfriendly. I think we'd have a bit of a revolt if we included it by default. Also some of these settings seem hard to infer?

@mkendall07
Copy link
Member Author

sounds like a good topic to bring to the PMC.

@patmmccann
Copy link
Collaborator

patmmccann commented Aug 14, 2024

Discussion result: #11184 (comment) may be "the sense of the publishers" on this. what's the goal on providing this? It also doesnt seem possible to detect the publisher future intent to resfresh or not and fill out the refsettings object.

@mkendall07
Copy link
Member Author

thanks for the link @patmmccann. I agree that automatically sending half the data (just refresh depth which can be inferred) is a bit half baked. I'll close this for now. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants