Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: utility to get position of slot element on page #11963

Open
patmmccann opened this issue Jul 12, 2024 · 1 comment
Open

Feature request: utility to get position of slot element on page #11963

patmmccann opened this issue Jul 12, 2024 · 1 comment

Comments

@patmmccann
Copy link
Collaborator

function getBannerCoords(id) {
is a very expensive operation

Source: https://gist.github.com/paulirish/5d52fb081b3570c81e3a

I propose we add a linting rule to disallow. Undertone team, is this calculation important to you? Is there anotherv way to get it?

@dgirardi dgirardi changed the title Undertone bid adapter: layout calculation on bid Feature request: utility to get position of slot element on page Jul 15, 2024
@dgirardi
Copy link
Collaborator

dgirardi commented Jul 15, 2024

  • Update percentInView to de-dupe multiple calls within an auction
  • refactor adapters to use it
  • add a linter rule to prevent use of getBoundingRect*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Dev
Development

No branches or pull requests

2 participants