Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various modules: not using our communication methods #11838

Closed
patmmccann opened this issue Jun 20, 2024 · 3 comments · Fixed by #12236
Closed

Various modules: not using our communication methods #11838

patmmccann opened this issue Jun 20, 2024 · 3 comments · Fixed by #12236
Assignees
@mkomorski
Labels
bug

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Jun 20, 2024 •
edited
Loading

Type of issue

Bug

Description

The last three here
https://github.com/search?q=repo%3Aprebid%2FPrebid.js++sendbeacon+path%3A%2F%5Emodules%5C%2F%2F&type=code

cwire, 33across, sirdata should all import sendbeacon

Steps to reproduce

Test page

Expected results

Actual results

Platform details

Other information
@patmmccann patmmccann changed the title Various modules: not using our communication methods Triggerpixel: change to keepalive? & Various modules: not using our communication methods Jun 30, 2024
@patmmccann
Copy link
Collaborator Author

Article espousing benefits of keepalive https://www.stefanjudis.com/today-i-learned/fetch-supports-a-keepalive-option-to-make-it-outlive-page-navigations/

@patmmccann patmmccann changed the title Triggerpixel: change to keepalive? & Various modules: not using our communication methods Various modules: not using our communication methods Jul 1, 2024
@patmmccann
Copy link
Collaborator Author

patmmccann commented Jul 1, 2024 •
edited
Loading

Plan: implement new method in ajax.js ( @nathan-pubx ) in #11425 then later migrate the other three adapters using it on their behalf.

@nathan-pubx nathan-pubx mentioned this issue Jul 2, 2024
Merged
@dgirardi
Copy link
Collaborator

Why is this blocked @patmmccann ?

@patmmccann patmmccann added the bug label Sep 9, 2024
mkomorski pushed a commit that referenced this issue Sep 12, 2024
#11838 send beacon fix
e44eaa5
@mkomorski mkomorski mentioned this issue Sep 12, 2024
Merged
10 tasks
@dgirardi dgirardi linked a pull request Sep 12, 2024 that will close this issue
Various modules: Send beacon wrapping fix #12236
Merged
10 tasks
patmmccann added a commit that referenced this issue Sep 24, 2024
@mkomorski @patmmccann
Various modules: Send beacon wrapping fix (#12236)
77b974d 
* #11838 send beacon fix

* Update cwireBidAdapter.js

* Update 33acrossAnalyticsAdapter.js

---------

Co-authored-by: Marcin Komorski <[email protected]>
Co-authored-by: Patrick McCann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkomorski mkomorski

Labels
bug
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various modules: Send beacon wrapping fix prebid/Prebid.js
3 participants
@patmmccann @dgirardi @mkomorski