Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharethrough bid adapter generates invalid sync URLs #10478

Closed
spormeon opened this issue Sep 13, 2023 · 4 comments
Closed

Sharethrough bid adapter generates invalid sync URLs #10478

spormeon opened this issue Sep 13, 2023 · 4 comments
Labels

Comments

@spormeon
Copy link

Type of issue

consent being added to domain and throwing error

Description

Steps to reproduce

in V8.11.0 there is no error , test page: https://cdn.adysis.com/VideoDemo/DemoSite/pages/BBH.html

in V8.13.0 a error is being thrown and it looks like consent is being added onto the domain ( no idea where this is coming from):
DevTools_-cdn_adysis_com_VideoDemo_DemoSite_pages_BBH8_13_0_html_and_Lee_Westwood_v_Ian_Poulter_v_Jimmy_Bullard__It’s_The_Nuts__-_YouTube_🔊

test page: https://cdn.adysis.com/VideoDemo/DemoSite/pages/BBH8.13.0.html

Expected results

no error to be throw and no domain url with consent on it

Actual results

error being thrown with domain url being created with what looks like consent etc on it

Platform details

chrome, mac, V8.11.0 V's V8.13.0

Other information

@dgirardi
Copy link
Collaborator

I believe this was introduced by #10388; sometimes the sharethrough bid adapter will return an invalid user sync URL (paging @jefftmahoney):

image

I don't think this affects anything beside sharethrough's user syncs, so from a publisher's point of view it should be close to inconsequential.

@dgirardi dgirardi changed the title some error between 8.11.0 & 8.13.0, creating a url with what looks like consent etc on it - Video Sharethrough bid adapter generates invalid sync URLs Sep 13, 2023
@dgirardi dgirardi added the bug label Sep 13, 2023
@deivydas
Copy link
Contributor

deivydas commented Sep 22, 2023

Hey @spormeon,
This issue should be fixed now.
We have noticed that there were empty strings delivered in some cases as user sync urls.
We have introduced measures in our backend to not have this situation.

@lcorrigall
Copy link

Can this be closed?

@lcorrigall lcorrigall moved this from Triage to Needs OP in Prebid.js Tactical Issues table Sep 25, 2023
@spormeon
Copy link
Author

@lcorrigall fine by me, if @deivydas is sure its sorted out now, backend logs disapeared?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

5 participants