-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floors module: default floor price does not apply #10445
Comments
Are you saying you set a skip rate and you are surprised there is no floor when the floor logic is skipped? |
As an aside I generally read this logic as confusing as well, conflating random skip and no match; these are very different for analytics purposes. I remember we had an annoying time getting the set skip rate to match observed skip rate because some unexpected no matches were messing it up. |
I believe the documentation is incorrect in this:
from my testing both |
I have exactly the same problem. I've set up the Prebid configuration just like OP, and the SSP bids below the default floor. They don't seem to see any floor in the requests I send them at all |
A workaround, to achieve what I think
|
@dgirardi In my config, I used a similar notation:
Professor Prebid sees the config, but the SSPs bid below. |
@modessef1 when floors are set globally through
Your |
Type of issue
Bug or question
Description
Prebid.js documentation says, that it is enough to configure adUnit with the default value, but there is no example with global floor.
link to documentation
By looking into the source code, it seems that is necessary to have values in floors object link to source code and only
default
is insufficient, andskipped
value to floor data is set to true, and thereforegetFloor()
does not exist.Is this approach correct overall? If not, could you provide an example with the default floor value?
Also, is it possible to define default value while calling
setConfig
?Expected results
Bid adapter to be able to get the default floor value.
Actual results
getFloor()
does not exist.The text was updated successfully, but these errors were encountered: