Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dynamic renderer in PBS adapter #10434

Open
ccorbo opened this issue Sep 5, 2023 · 2 comments · May be fixed by #10433
Open

Support for dynamic renderer in PBS adapter #10434

ccorbo opened this issue Sep 5, 2023 · 2 comments · May be fixed by #10433
Assignees
Labels

Comments

@ccorbo
Copy link
Contributor

ccorbo commented Sep 5, 2023

Type of issue

Feature Request

Description

I am opening this issue to initiate a discussion regarding the implementation of support for a dynamic renderer within the Prebid Server bid adapter.

This proposed feature aims to enable the inclusion of a renderer URL within the bid response. With the presence of this field, the necessity for defining the renderer at the ad unit level would be eliminated. Consequently, the validation criteria for a valid bid would need to be adjusted to accommodate this new field.

To implement this, the process of setting the renderer on the bid requires updates. During a local POC I updated the getPreparedBidForAuction function in auction.js, this was updated to set the bid.renderer function, using the new renderer url that was passed in via the bid response.

It's important to note that supporting a dynamic renderer and incorporating bid renderer installation into the core of Prebid.js would necessitate a standardized API for each renderer. Currently, different adapters have varying methods for rendering an outstream video player.

An example of standardization for custom renderers for native ad units is in the linked documentation. The same API could be required in supporting this feature, that is required in the native ad unit case.

https://docs.prebid.org/prebid/native-implementation.html#43-implementing-the-custom-renderer-scenario

I am seeking feedback on this requested feature.

I am also attaching a draft PR that shows an example implementation of the above described feature:
#10433

@patmmccann
Copy link
Collaborator

@ccorbo could you align your pr with the new location specified in prebid/prebid-server#3085

@ccorbo
Copy link
Contributor Author

ccorbo commented Sep 11, 2023

@ccorbo could you align your pr with the new location specified in prebid/prebid-server#3085

Yes will update the linked PR with the new spec.

@patmmccann patmmccann linked a pull request Oct 11, 2023 that will close this issue
9 tasks
@patmmccann patmmccann moved this from PR submitted to Needs Req in Prebid.js Tactical Issues table Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Req
Development

Successfully merging a pull request may close this issue.

3 participants