Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans for date-fns v2? #4

Open
motin opened this issue Nov 14, 2018 · 10 comments
Open

Plans for date-fns v2? #4

motin opened this issue Nov 14, 2018 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@motin
Copy link

motin commented Nov 14, 2018

Great job in making it possible to work with timezones using date-fns v1! How well does this work with date-fns v2 alpha currently? Will this library live on after v2 release or deprecated once v2 is available and date-fns/date-fns#707 is merged? Or will you port your changes to a new PR for v2?

@prantlf
Copy link
Owner

prantlf commented Nov 17, 2018

Thanks for the warn words, @motin! I use only public interface of parse and format; it will depend on if v2 breaks it or not. I should like to have a look it.

I intend to maintain this library for both v1 and v2. v2, once I get my hands on it :-) I'll consider opening a PR for date-fns.

date-fns/date-fns#707 takes a different approach - it uses the native Intl API. You need a modern browser with its support, or a Node.js build with the full ICU (or the full-icu-data module) if you use it.

I integrated timezone-support, which uses the time zone data from a JavaScript module; either a bundled one or a custom one. It is more flexible, than the native API, but it is customizable and running everywhere today.

@prantlf prantlf added this to the date-fns-v2 support milestone Nov 17, 2018
@prantlf prantlf self-assigned this Nov 17, 2018
@prantlf prantlf added the enhancement New feature or request label Nov 17, 2018
@stevensacks
Copy link

V2 is out now and its format function has changed quite a bit, but I'm not sure if it causes breaking changes for this library. I haven't noticed any issues with formatToTimeZone yet but I'm only using it at its most basic thus far.

@ngehlert
Copy link

any updates on this? is v2 support planned? do you need any help? or is this project done?

@jkeen
Copy link

jkeen commented May 13, 2020

I'm still on date-fns 1.x because of this compatibility uncertainty.

@osdiab
Copy link

osdiab commented May 29, 2020

Looks like this project is unmaintained? no activity for a year

@ngehlert
Copy link

looks like it. I recently upgraded to date-fns 2x in a project and just extracted and build the stuff I needed by myself... :(

@jkeen
Copy link

jkeen commented Dec 9, 2020

@ngehlert Got anything you can PR?

@jkeen
Copy link

jkeen commented Dec 9, 2020

Wait wait wait, did v2 make this library unnecessary? https://date-fns.org/v2.16.1/docs/Time-Zones

@erikt9
Copy link

erikt9 commented Dec 9, 2020

@jkeen That library requires the browser to support parts of Intl that IE lacks. This library works with IE.

@jkeen
Copy link

jkeen commented Dec 9, 2020

@erikt9 Ahh is that all? That helps me out, because my app doesn't support IE. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants