plugins/radius: incompatible cast

[yarda]

The following was found by static analysis, I think it could cause problems on 64 bits:

"Error: INCOMPATIBLE_CAST (CWE-119):
ppp-ppp-2.5.0/pppd/plugins/radius/avpair.c:756: incompatible_cast: Pointer ""&pair->lvalue"" points to an object whose effective type is ""unsigned int"" (32 bits, unsigned) but is dereferenced as a wider ""long"" (64 bits, signed). This may lead to memory corruption.
#  754|   	    case PW_TYPE_DATE:
#  755|   		strftime (buffer, sizeof (buffer), ""%m/%d/%y %H:%M:%S"",
#  756|-> 			  gmtime ((time_t *) & pair->lvalue));
#  757|   		strncpy(value, buffer, lv-1);
#  758|   		break;"

[yarda]

ppp-2.5.0

[paulusmack]

I agree, on a platform with 64-bit time_t, particularly a big-endian platform, this wouldn't be right.