Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check names for numeric values #83

Open
exussum12 opened this issue Dec 20, 2018 · 1 comment · May be fixed by #86
Open

Check names for numeric values #83

exussum12 opened this issue Dec 20, 2018 · 1 comment · May be fixed by #86

Comments

@exussum12
Copy link
Collaborator

Eg self::SOMETHING_SIX = 6; should be disallowed

Will need to work out languages but default to English
@povils
Copy link
Owner

povils commented Dec 25, 2018

Hey,
Nice idea:) I wouldn't put it as strict check but more like warning/suggestion type of check:)

exussum12 added a commit to exussum12/phpmnd that referenced this issue Jan 28, 2019
@exussum12
Check for named constants
ebd6a7e 
Eg remove $six = 6

or $week = 7

These sorts of numbers are still magic, fixes povils#83
@exussum12 exussum12 linked a pull request Jan 28, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for named constants exussum12/phpmnd
2 participants
@exussum12 @povils