Radio Buttons dont stay selected on side swipe

[hallahan]

This was an issue from way back that got fixed. I think the the latest custom input sprint, it sneaked back in. This is an annoying bug. Should be an easy fix.

[hallahan]

This one is a doozy. I've pinpointed the issue.

It's a bug in TagEdit. We're referencing a tagValue property that actually is getting set right before we Save to ODK Collect. Since we haven't done that yet, it's looking at a stale value that reflects what we read previously from the OSM element, and not what was last entered in the UI.

The tagVal property you can see set in private void updateTagInOSMElement().

https://github.com/AmericanRedCross/OpenMapKitAndroid/blob/c107c89f48065c1fab93790257f8f997be2cee35/app/src/main/java/org/redcross/openmapkit/tagswipe/TagEdit.java#L158-L195

This is the only time the property is set.

[hallahan]

This bug should also apply to text inputs. Make sure solution fixes that too. This is actually important, and I need to be mindful on how this works when crafting constraints.

[hallahan]

Do we want to update the OSM Element every time the UI changes, or do we want to wait until we save to make those updates.

If we wait, nothing is saved unless we press save.

If we do an update every time, that means a save should encompass other elements that were edited. Would a save have several ways in it?

This might link to bug #113. Might be good to get to the crux of the matter.

[hallahan]

Fixed this bug. Unfortunately, it does not fix #113.