Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date_Type missing for >500 individuals #25

Open
stschiff opened this issue Aug 12, 2021 · 4 comments
Open

Date_Type missing for >500 individuals #25

stschiff opened this issue Aug 12, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@stschiff
Copy link
Member

I checked how Date_Type is filled currently with something equivalent to

trident list --remote --individuals -j Date_Type | cut -f4 | sort | uniq -c

yielding

3181 C14
2356 contextual
7404 modern
 534 n/a

Apparently we have 534 missing values in that column, which needs fixing.

@nevrome nevrome mentioned this issue Oct 9, 2021
Closed
11 tasks
@stschiff
Copy link
Member Author

stschiff commented Dec 1, 2021

Is this still the case? Anyway a good project for @dhananjaya93, in my view.

@stschiff stschiff added the bug Something isn't working label Dec 1, 2021
@nevrome
Copy link
Member

nevrome commented Dec 1, 2021

@dhananjaya93 and I realized that this is not as trivial as it might seem. Many of these n/a values mean, that the respective samples/individuals have no clear dating in the respective papers. They are not directly dated and the authors sometimes don't make clear, numeric statements how they should be temporally located.

So we could set a lot of these n/a values to contextual, but to really solve this beyond a superficial fix would mean, to go into the papers and make an authoritative decision about the general age range relevant for each individual.

@stschiff
Copy link
Member Author

stschiff commented Dec 1, 2021

OK, but I would think David may have already made decisions about contextual date ranges? Can we check that?

@nevrome
Copy link
Member

nevrome commented Dec 2, 2021

True! That's an idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants