Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git-attribute setting for line endings #215

Open
stschiff opened this issue Oct 23, 2024 · 0 comments
Open

Git-attribute setting for line endings #215

stschiff opened this issue Oct 23, 2024 · 0 comments

Comments

@stschiff
Copy link
Member

We currently have an attribute setting * text eol=lf in our .gitattributes file for this repository. I don't know exactly what it does, but it seems to convert CRLF-line endings to LF line endings upon commits. While this seems to be clever, as it implicitly "fixes" wrong Windows-line endings, it makes checksum-validation inconsistent between platforms.

If I locally commit a file with CRLF-endings and compute checksums, those checksums will not validate anymore on another user's platform if they have intermittently pulled my changes through git. This inconsistency is rather puzzling and surprising. I would suggest to remove this setting and accept "wrong" CRLF-line endings via git, and move the responsibility downstream to committing users, for example by adding a feature to `validate´ to check for line-endings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant