Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Create a Setting to Change the Thickness of the Active Hint #1631

Open
jlangson opened this issue Jun 4, 2023 · 3 comments · May be fixed by #1641
Open

Feature Request: Create a Setting to Change the Thickness of the Active Hint #1631

jlangson opened this issue Jun 4, 2023 · 3 comments · May be fixed by #1641
Labels
enhancement New feature or request

Comments

@jlangson
Copy link

jlangson commented Jun 4, 2023

Being able to change the thickness of active hint would be helpful because sometimes it is too thick and blocks information from adjacent screens. For example, the active hint with Discord app makes it hard to see the discord indicator for new posts.

@leviport leviport added the enhancement New feature or request label Jun 5, 2023
@shans10
Copy link

shans10 commented Jun 29, 2023

Hello, I managed to implement this. It is working on OpenSUSE Tumbleed on Gnome 44, I just had a question what should be the min and max values for the width, I have set min to 1 which makes sense since 0 means no border and we already have a toggle for that but I am wondering what would be appropriate max value I am currently using 15?

Edit: Above 5px the borders are not uniform on all sides.

@leviport
Copy link
Member

Awesome! Feel free to open a pull request, even if the borders are uneven above 5px. Maybe someone will have an idea and be able to help make it uniform.

Also, I wonder if it would also be nice to add a setting that lets you determine whether the hint should be aligned to the outside, inside, or in the middle of the window edge? Not trying to be choosy beggar or anything, just sharing ideas 😅

@shans10 shans10 linked a pull request Jun 29, 2023 that will close this issue
@shans10
Copy link

shans10 commented Jun 29, 2023

Also, I wonder if it would also be nice to add a setting that lets you determine whether the hint should be aligned to the outside, inside, or in the middle of the window edge? Not trying to be choosy beggar or anything, just sharing ideas 😅

Thanks for your valuable input it seems like a good idea however I am not sure how to go about it right now so I will take a look again and try to implement it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants