Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] ViMode: Ctrl+D maps to PageDownByHalf #165

Open
Shinyzenith opened this issue Mar 21, 2024 · 3 comments
Open

[Feature Request] ViMode: Ctrl+D maps to PageDownByHalf #165

Shinyzenith opened this issue Mar 21, 2024 · 3 comments

Comments

@Shinyzenith
Copy link

Hi, I have written a patch set to support this. I also want to write one for control+U eventually.

The patch only needs some cleanup but before opening the PR I just wanted to ensure that this is in the scope of the project.

@jackpot51
Copy link
Member

Vi mode is handled by the modit crate: https://github.com/pop-os/modit, it would be best to submit changes there.

@Shinyzenith
Copy link
Author

I initially tried to implement it at the modit level but couldn't figure out the flow of keybind handling correctly. Would you mind if I shared my patch here for some insight into how I can do it better? Should I move the issue to modit crate tracker?

@Shinyzenith
Copy link
Author

Shinyzenith commented Apr 5, 2024

Hi, it seems all control based keybindings are done at the editor level and not in modit. Please correct me if I am wrong / kindly point me in the direction of how to call control based bindings from modit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants