-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad font rendering when fractionally scaled #140
Comments
Can you provide the version of Cosmic-Edit you're using? This can be found on Pop!_OS, Ubuntu, and many other Debian derivatives by running the following in a terminal:
I just need the value next to |
@XV-02 I run fedora and install from git (just updated to today). Details of my setup are: Operating System: Fedora Linux 40 I run both KDE and Cosmic. |
Turned out I had a copy of cosmic-edit in my user bin dir, so i was never actually seeing updates when I rebuilt sysext. |
Re-opening as this is still true. Running bcc1ad8 |
From what I can see the bad rendering is in set places (at default window size here) |
What graphics card and driver do you have? Does it look like this if you change the WGPU renderer, or disable GPU rendering by removing the |
Hmm:
Using mesa 24.0.0 for Intel, 550.54.14 for nvidia. I'll try without wgpu feature if I have time. |
The main reason for this is that the custom control cosmic-edit uses for text renders it to an image and the image size is calculated based on the logical size multiplied by the scale factor. When using a fractional size, that can sometimes end up being a size that doesn't exactly fit into integer logical pixels and then it scales incorrectly. I'm going to replace this workaround now that iced directly supports rendering cosmic_text buffers. |
Ah I see, that explains why resizing to a particular size helped. |
This is partially improved by 2bfcfdf. It searches for a pixel size that is an integer in both the logical and physical coordinates. Unfortunately it does not work fully with the wgpu renderer. When I have more time I will switch to using a different rendering technique that will both improve performance and fix this issue when using the wgpu feature. |
The screenshot demonstrates the issue. Fractional scaling is 125% here. It happens on most scales except integer.
Not sure what other info is valuable. This does happen in both KDE and Cosmic.
The text was updated successfully, but these errors were encountered: