-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for application/json on POST? #329
Comments
Hey @dhilst thanks for opening this. Totally agree json easier than encoded form also. |
Are you willing to review PRs? I'm not fluent on go but it would be a good challenge |
@dhilst I certainly will, but couldn't say when I'm a little rushed myself at the moment and there are a couple open that I've committed to review but haven't had the opportunity. It might also be better to get some more input here, before digging in, just to make sure the feature is needed and won't impact anything. @nilslice is the man to input on this, but he's also quite busy ATM. |
No problem I'm usually busy too, we do at our time. I'll wait for @nilslice input 👍 |
@dhilst - thanks for the kind words, glad you're finding Ponzu useful! But, if you were interested in a PR and wanted a good place to start: The I suppose the expected incoming JSON structure should be identical to the output in a content API response. Before I can merge any PRs though, there is some work to get the project building on CI properly, and then converting it to support Go modules. If you're interested in helping out with those as well, it would be greatly appreciated. |
Hi @nilslice re the CI piece and what you are thinking there - is that worth capturing in a separate issue?
Project is on CircleCI currently are you thinking of another approach diff provider or just going further with current process? I find ponzu prs quite hard to test - there are more moving parts than most projects with the repo the server and application CLI.
Anything we can do to making testing contributions through a CI process would be great. I wondered about using github actions to create a docker file that runs a built version of the submission with default project template?
Happy to try help with thoughts and some graft where possible.
On a phone - I’ll edit it later.
|
Hi @nilslice I agree with @olliephillips with handling this CI stuff in another module. I'm kind of busy too, but I think I will have some time in the next months so I can dive in this |
Here it is, there is some duplicated code, I'm addressing that |
There is a big note documentation quoting that
Content-Type
should bemultipart/form-data' otherwise we get a big 400 error, is there any way to accept
application/json`? There are a lot of tolls that dump json, and working with json is usually easier than working with encoded form.I understand that is not possible to upload stuff with
application/json
and we're talking about CMS but this is a great tool for creating API with Let's Encrypt integration would be wonderful if could accept JSON nativelyAnyway, great project and the Let's Encrypt feature is a dream that came true
The text was updated successfully, but these errors were encountered: