Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage customization for react native #135

Open
ryanleecode opened this issue Mar 1, 2024 · 1 comment
Open

storage customization for react native #135

ryanleecode opened this issue Mar 1, 2024 · 1 comment

Comments

@ryanleecode
Copy link

Right now polyfire is using only local storage. This is a problem in react native since local storage doesn't exist and would be a problem in a web extension context as well. suggestion is to make the storage object generic and allow the user to pass in a storage object as a parameter.

@lowczarc
Copy link
Contributor

lowczarc commented Mar 8, 2024

You're right, it might be a better way of doing it.
I'm pretty sure this is not the only place where it depends on node/browser API though.

We should add tests for theses environment first or we will definitely break them accidentally at some point since we are developing mainly on node/browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants