Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pl.datetime does not respect leftmost-argument naming rule #18808

Open
orlp opened this issue Sep 18, 2024 · 2 comments · May be fixed by #20138
Open

pl.datetime does not respect leftmost-argument naming rule #18808

orlp opened this issue Sep 18, 2024 · 2 comments · May be fixed by #20138
Labels
accepted Ready for implementation bug Something isn't working python Related to Python Polars rust Related to Rust Polars
Milestone
2.0.0

Comments

@orlp
Copy link
Collaborator

orlp commented Sep 18, 2024

pl.datetime currently always returns a column with name datetime instead of the name of the leftmost input.
@orlp orlp added bug Something isn't working python Related to Python Polars rust Related to Rust Polars accepted Ready for implementation labels Sep 18, 2024
@orlp orlp added this to the 2.0.0 milestone Sep 18, 2024
@github-project-automation github-project-automation bot moved this to Ready in Backlog Sep 18, 2024
@barak1412
Copy link
Contributor

@orlp Are you sure it belongs to 2.0.0? Such bugs were fixed without (e.g. #18512).

@orlp
Copy link
Collaborator Author

orlp commented Sep 23, 2024

@barak1412 I've decided to do so because it will break most code that currently use pl.datetime.

@haocheng6 haocheng6 linked a pull request Dec 3, 2024 that will close this issue
Open
@haocheng6 haocheng6 mentioned this issue Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted Ready for implementation bug Something isn't working python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Status: Ready
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

fix(rust): Fix pl.datetime to follow leftmost-argument naming rule haocheng6/polars
2 participants
@orlp @barak1412