Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pl.concat(how='horizontal') should be strict by default #19133

Open
coastalwhite opened this issue Oct 8, 2024 · 2 comments · May be fixed by #20019
Open

pl.concat(how='horizontal') should be strict by default #19133

coastalwhite opened this issue Oct 8, 2024 · 2 comments · May be fixed by #20019
Labels
enhancement New feature or an improvement of an existing feature good first issue Good for newcomers
Milestone
2.0.0

Comments

@coastalwhite
Copy link
Collaborator

Description

First, the pl.concat should get a strict option. This should reject concatenating DataFrame's that are not the same height. Then, for 2.0, it should be enabled by default.
@coastalwhite coastalwhite added good first issue Good for newcomers enhancement New feature or an improvement of an existing feature labels Oct 8, 2024
@coastalwhite coastalwhite added this to the 2.0.0 milestone Oct 8, 2024
@not-so-rabh
Copy link

HI @coastalwhite new here can i take this up?

@coastalwhite
Copy link
Collaborator Author

Yes, go head!

@nimit nimit linked a pull request Nov 27, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature good first issue Good for newcomers
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

feat: Add strict parameter to pl.concat(how='horizontal') nimit/polars
2 participants
@coastalwhite @not-so-rabh