Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code to have easily configurable subreddits #606

Open
robdy opened this issue Oct 23, 2017 · 1 comment
Open

Refactor code to have easily configurable subreddits #606

robdy opened this issue Oct 23, 2017 · 1 comment

Comments

@robdy
Copy link
Member

robdy commented Oct 23, 2017

The idea here is to make it easier for initial configuration by having subreddit names saved to variables and then adjust only this variables if necessary.

This would allow us to make pushing easier as we won't need to edit subreddit names in any file back and forth.
@baudtack
Copy link

I am currently working on this.

baudtack added a commit to baudtack/flairhq that referenced this issue Nov 2, 2017
@baudtack
Fixes pokemontrades#606
b678dc7 
Refactored backend code to use settings in config for two subs
instead of hardcoded references. Done in the dumbest way to avoid
breaking anything. Still should be refactored at some point
to support arbitrary numbers of subs with arbitrary flair sets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baudtack @robdy