Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide meaningful error message to users when .harmony file is malformed #168

Open
skorper opened this issue Apr 29, 2024 · 0 comments
Open

Provide meaningful error message to users when .harmony file is malformed #168

skorper opened this issue Apr 29, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@skorper
Copy link
Contributor

skorper commented Apr 29, 2024

--subset requests use Harmony behind the scenes, and we use a .harmony file to track the status of the job. If, for whatever reason, the .harmony file is malformed or missing fields, the error raised to users will be confusing (e.g. JsonDecodeError). We should handle this case more explicitly and raise a meaningful error to users.
@skorper skorper added enhancement New feature or request good first issue Good for newcomers labels Apr 29, 2024
skorper pushed a commit that referenced this issue May 9, 2024
@avvalenx
added error messages for malformed and missing key in .harmony file t…
d6953f2 
…o fix issue #168 (#170)

* added error messages for malformed and missing key in .harmony file

* documented .harmony error log changes in chagelog

* updated changelog

---------

Co-authored-by: Anthony Valen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skorper