Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation warnings #147

Open
vkomenda opened this issue Jun 11, 2019 · 0 comments
Open

Fix compilation warnings #147

vkomenda opened this issue Jun 11, 2019 · 0 comments

Comments

@vkomenda
Copy link

There are too many warning messages. Error messages drown in them and don't fit into the terminal buffer. Maybe some of them are fixed in v2.4.6, in which case a rebase onto v2.4.6 should be part of the fix. A few of the warnings are as follows:

  --> ethcore/src/miner/pool_client.rs:75:14
   |
75 |     engine: &'a EthEngine,
   |                 ^^^^^^^^^ help: use `dyn`: `dyn EthEngine`

warning: trait objects without an explicit `dyn` are deprecated
  --> ethcore/src/miner/pool_client.rs:76:16
   |
76 |     accounts: &'a LocalAccounts,
   |                   ^^^^^^^^^^^^^ help: use `dyn`: `dyn LocalAccounts`

warning: trait objects without an explicit `dyn` are deprecated
   --> ethcore/src/miner/pool_client.rs:101:15
    |
101 |         engine: &'a EthEngine,
    |                     ^^^^^^^^^ help: use `dyn`: `dyn EthEngine`

warning: trait objects without an explicit `dyn` are deprecated
   --> ethcore/src/miner/pool_client.rs:102:17
    |
102 |         accounts: &'a LocalAccounts,
    |                       ^^^^^^^^^^^^^ help: use `dyn`: `dyn LocalAccounts`

warning: trait objects without an explicit `dyn` are deprecated
  --> ethcore/src/pod_account.rs:82:43
   |
82 |     pub fn insert_additional(&self, db: &mut HashDB<KeccakHasher, DBValue>, factory: &TrieFactory<KeccakHasher, RlpCodec>) {
   |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn HashDB<KeccakHasher, DBValue>`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant