ETH Net props for Callisto #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 90
💛 - Coveralls |
vbaranov
reviewed
Mar 30, 2020
There was a problem hiding this comment.
@yograterol I left the comments. Some links should be fixed. The rest looks good to me.
| it(`${claimPrefix} Ethereum Classic`, () => { | ||
| assert.equal(explorerLinks.getExplorerAccountLinkFor('0xd8fe15886d2dcbc5d7c06394beb417aadaf1eee0', '61'), 'https://blockscout.com/etc/mainnet/address/0xd8fe15886d2dcbc5d7c06394beb417aadaf1eee0') | ||
| it(`${claimPrefix} Callisto Network`, () => { | ||
| assert.equal(explorerLinks.getExplorerAccountLinkFor('0xd8fe15886d2dcbc5d7c06394beb417aadaf1eee0', 820), 'https://explorer2.callisto.network/address/0xd8fe15886d2dcbc5d7c06394beb417aadaf1eee0') |
There was a problem hiding this comment.
I've checked that address page in Callisto explorer is available at /addr/... path and not at /address/. I suppose path should be changed here in the tests and in the logic.
| @@ -83,6 +83,9 @@ describe('eth-net-props', () => { | |||
| it(`${claimPrefix} Ethereum Classic`, () => { | |||
| assert.equal(explorerLinks.getExplorerTxLinkFor('0x430c90335b32fdcd92e54991668023d58b72bce836e204a81c6d97506c7137e5', 61), 'https://blockscout.com/etc/mainnet/tx/0x430c90335b32fdcd92e54991668023d58b72bce836e204a81c6d97506c7137e5') | |||
| }) | |||
| it(`${claimPrefix} Callisto Network`, () => { | |||
| assert.equal(explorerLinks.getExplorerTxLinkFor('0x430c90335b32fdcd92e54991668023d58b72bce836e204a81c6d97506c7137e5', 820), 'https://explorer2.callisto.network/tx/0x430c90335b32fdcd92e54991668023d58b72bce836e204a81c6d97506c7137e5') | |||
There was a problem hiding this comment.
I would change to the really existent tx hash in Callisto chain. The current one leads to 404 page.
| @@ -119,6 +122,9 @@ describe('eth-net-props', () => { | |||
| it(`${claimPrefix} Ethereum Classic`, () => { | |||
| assert.equal(explorerLinks.getExplorerTokenLinkFor('0x1ac1c8b874c7b889113a036ba443b082554be5d0', '0xdb23145b64D0E1e15dedf47abd77cCaf3F2327d7', 61), 'https://blockscout.com/etc/mainnet/address/0xdb23145b64D0E1e15dedf47abd77cCaf3F2327d7/tokens/0x1ac1c8b874c7b889113a036ba443b082554be5d0/token_transfers') | |||
| }) | |||
| it(`${claimPrefix} Callisto Network`, () => { | |||
| assert.equal(explorerLinks.getExplorerTokenLinkFor('0x1ac1c8b874c7b889113a036ba443b082554be5d0', '0xdb23145b64D0E1e15dedf47abd77cCaf3F2327d7', 820), 'https://explorer2.callisto.network/address/0x1ac1c8b874c7b889113a036ba443b082554be5d0') | |||
There was a problem hiding this comment.
The same comment regarding incorrect path to address of the token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're working on integrating Callisto Network in Nifty Wallet and we must start from this project first adding relevant info about RPC, explorer and Chain Code.