-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider supporting YAML for hydra configs #165
Comments
I see PR#166 in theory handles this Issue .. but nothing on the PR request has happened?? |
The issue I raised privately (@taurenk and I work together) is that of adding another dependency. At one point I was on a crusade to slim Hydra (core) in size. My reason was that I wanted us to be able to claim that Hydra is a light-weight library. I routinely use
One way to support this might be to build a HydraPlugin (https://github.com/flywheelsports/hydra/blob/master/plugins.md) that adds yaml to json conversion. The following are examples of HydraPlugins: |
Personally I don't have a "dog in this hunt" as it were -- I'm a TOML fan :) The reason I bring this up though is because for those looking from the outside -- seeing "old" PR requests apparently "ignored" is not a good sign for an Open Source project. The goal should be to merge or reject PR's ASAP .. and not leave them lingering .. But that's my opinion .. |
@sjmcdowall thanks for the feedback. I've asked @taurenk to review here. |
This might be useful.
https://www.npmjs.com/package/node-yaml
The text was updated successfully, but these errors were encountered: