Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation should not go to an infinite resolution loop on circular dependencies #124

Open
Tracked by #100
zkochan opened this issue Sep 20, 2023 · 0 comments
Open
Tracked by #100

Installation should not go to an infinite resolution loop on circular dependencies #124

zkochan opened this issue Sep 20, 2023 · 0 comments

Comments

@zkochan
Copy link
Member

zkochan commented Sep 20, 2023 •
edited
Loading

There are multiple tests related to circular dependencies in the main pnpm repository. We can use the same packages to test pacquet.

This is where pnpm exits on circular dep:

https://github.com/pnpm/pnpm/blob/98377afd3452d92183e4b643a8b122887c0406c3/pkg-manager/resolve-dependencies/src/resolveDependencies.ts#L1195-L1203

Related task: #127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zkochan