Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulated packets and raw UDP packets should be listed separately #47

Open
SOF3 opened this issue Aug 31, 2019 · 0 comments
Open

Encapsulated packets and raw UDP packets should be listed separately #47

SOF3 opened this issue Aug 31, 2019 · 0 comments
Labels
Type: Enhancement

Comments

@SOF3
Copy link
Member

SOF3 commented Aug 31, 2019

Some packets are only received/sent as UDP packets, and some are only inside the EncapsulatedPacket buffer. However both types of packets are declared in MessageIdentifiers.php and src/protocol without distinction (probably legacy from RakNet itself).

They should be declared separately for clarity.
dktapps added a commit that referenced this issue Apr 8, 2021
@dktapps
Added a ConnectedPacket class
bd8b753 
this goes some way towards addressing #47.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dktapps @SOF3