Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correlated noise model #236

Open
pmelchior opened this issue Feb 15, 2021 · 0 comments
Open

correlated noise model #236

pmelchior opened this issue Feb 15, 2021 · 0 comments
Labels

Comments

@pmelchior
Copy link
Owner

When we fit HSC + HST data, the noise model is incorrect because the pixels are correlated in HST coadds. In essence, we’re overfitting the HST data.

We could kill the correlation by whitening the noise, but that introduces extra noise. The best option is to modify the log likelihood function of Observation with a proper multivariate Gaussian with a given covariance matrix. The problem is: that matrix is large, and to good approximation banded. But autograd (or jax) don’t support sparse matrices (yet). The computation is identical to convolution with our apply_filter method, which we have already put into the autodiff path. So I suggest that we create a subclass CorrelatedObservation, where we overwrite the constructor with one that replaced weights by covariance, and that reimplements get_log_likelihood and log_norm for proper correlated signals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant