Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient for LowResObservation slower than expected #224

Open
pmelchior opened this issue Nov 10, 2020 · 1 comment
Open

Gradient for LowResObservation slower than expected #224

pmelchior opened this issue Nov 10, 2020 · 1 comment
Assignees

Comments

@pmelchior
Copy link
Owner

The runtime for gradient updates in LowResObservation is ~ an order of magnitude slower than the forward path. This is unusually slow, so there's probably a bottleneck. This issue is to run a profiler on the a few steps of Blend.fit with a single LowResObservation (i.e. different WCS between model and observation) to find out where the CPU cycles go.

If the culprit is obvious, we should find and replace it with a more performant implementation.

@pmelchior
Copy link
Owner Author

One possible clue: when running the multi-resolution tutorial, my machine is heavily swapping. The code only rarely reaches >100% CPU although it is naturally multi-threaded. So, it looks like something is pretty memory inefficient on my Mac (16 GB RAM).

So, possible culprits are

  • a single constant piece that is to large to be efficiently operated on
  • temporary pieces that are only required for a single iteration and then get discarded again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants