Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observation with global magnitude zeropoint #212

Open
pmelchior opened this issue Oct 8, 2020 · 1 comment
Open

Observation with global magnitude zeropoint #212

pmelchior opened this issue Oct 8, 2020 · 1 comment

Comments

@pmelchior
Copy link
Owner

Multi-observation fitting implicitly requires the amplitude in all observations to be comparable. Otherwise, elements of the spectrum parameters can have wildly different amplitude, with problems related to their step sizes.

Three options:

  1. Setting the step sizes for the spectrum differently for elements of different observations. This is cumbersome to set up because the user/we have to know which observations are present and what their count rates are when we define the source. In addition, it requires changes to proxmin because this effectively changes the metric in parameter space.
  2. Having the user normalize the amplitudes before defining the observation. Doable, but dangerous because the weights need to be normalized (by the user) accordingly.
  3. Defining a global flux unit convention (in Frame), e.g. 1 ADU / s / m^2. When set in model_frame, Observation.match would require it to be set in the observation frame and compute a rescaling factor c, which is applied to the model in render, so that the resulting model can be compared to the observation. This is effectively a mag zeropoint for each frame.

I prefer 3 because it is in line with the development spirit where we define common conventions for the frames. It's also fully consistent because we can put a Component into measure, and it can produce the correct flux scale in known and absolute units.

@herjy
Copy link
Collaborator

herjy commented Oct 8, 2020

I agree with 3 and my least preferred would be 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants