Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot does not appear in some cases if rangebreaks overlap #7270

Open
mofojed opened this issue Nov 14, 2024 · 0 comments
Open

Plot does not appear in some cases if rangebreaks overlap #7270

mofojed opened this issue Nov 14, 2024 · 0 comments
Labels
bug something broken P2 considered for next cycle

Comments

@mofojed
Copy link

mofojed commented Nov 14, 2024

I've created a Codepen for the issue: https://codepen.io/mofojed/pen/ZEgPJPN
In this case, the data spans a week, and range breaks are specified for a full holiday on Thursday, Nov 23, 2023 (Thanksgiving), and a half day on Friday, Nov 24, 2023. These specifications overlaps with other patterns for business days.
The chart does not appear. It looks like the rangebreaks that Plotly.js locates for the plot is:
Image
Where some of those overlap. It looks like that isn't taken into account when calculating the breaks length, so when there's overlap it will not generate a valid break length:

for(var i = 0; i < rangebreaksOut.length; i++) {

I think it would make sense to check for overlapping here. I'll see if it's possible to adjust holidays to not overlap with any existing business periods as well...

#5783 is similar

@gvwilson gvwilson added bug something broken P2 considered for next cycle labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken P2 considered for next cycle
Projects
None yet
Development

No branches or pull requests

2 participants