Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depends on Products.CMFPlone #119

Open
mauritsvanrees opened this issue May 31, 2023 · 4 comments
Open

Depends on Products.CMFPlone #119

mauritsvanrees opened this issue May 31, 2023 · 4 comments

Comments

@mauritsvanrees
Copy link
Member

Dependencychecker says:

Missing requirements
====================
     Products.CMFPlone.RegistrationTool.EmailAddressInvalid
     Products.CMFPlone.controlpanel
     Products.CMFPlone.controlpanel.events.ConfigurationChangedEvent
     Products.CMFPlone.utils.get_portal
     Products.CMFPlone.utils.set_own_login_name

Missing test requirements
=========================
     Products.CMFPlone.tests.utils.MockMailHost
     Products.CMFPlone.utils.get_portal

Some may be replaceable.
For the moment I will let dependencychecker ignore Products.CMFPlone.

cc @jensens @gforcada
mauritsvanrees added a commit that referenced this issue May 31, 2023
@mauritsvanrees
Configuring with plone/meta
00ea1af 
Temporarily ignore the Products.CMFPlone dependency.
See #119
@gforcada
Copy link
Member

gforcada commented Jun 1, 2023

Is plone.app.users meant to be a core package or a core addon? If the later then it should be fine that depends on CMFPlone, if the former then no 👍🏾

@mauritsvanrees
Copy link
Member Author

It is definitely a core package.

I guess it has a lot of Classic-only code as well, but I am sure restapi/Volto need at least parts of this package as well. Yes, plone.restapi has both a serializer and a service that use plone.app.users. Only some schemas are imported though, so indeed a good chance that Volto only needs at most 25 percent of this package.

mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Jun 1, 2023
@mauritsvanrees
[fc] Repository: plone.app.users
e33f97d 
Branch: refs/heads/master
Date: 2023-05-31T10:03:59+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@d0d560d

Improve help text for member fields option where fields are shown.

For Managers the restriction to not show a field on the user profile does not apply.
Fixes plone/Products.CMFPlone#3794

Files changed:
A news/3794.bugfix
M plone/app/users/field_extender.py
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-05-31T10:04:28+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@e28521b

Configuring with plone/meta

Files changed:
A .flake8
A .github/workflows/meta.yml
A news/53dc5b4c.internal
M .editorconfig
M .gitignore
M .meta.toml
M .pre-commit-config.yaml
M pyproject.toml
M tox.ini
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-05-31T10:06:39+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@80540f8

chore: removed no longer needed setup.cfg.

Files changed:
D setup.cfg
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-05-31T10:18:04+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@e9d8592

chore: fix codespell config.

Files changed:
M .meta.toml
M pyproject.toml
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-05-31T10:18:14+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@00ea1af

Configuring with plone/meta

Temporarily ignore the Products.CMFPlone dependency.
See plone/plone.app.users#119

Files changed:
M .meta.toml
M pyproject.toml
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-05-31T10:29:32+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@11e4cac

Comment out circular workflow.

It always fails currently, because of a dependency cycle in three different packages.

Files changed:
M .github/workflows/meta.yml
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-06-01T10:22:38+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@2cd926e

Revert "Comment out circular workflow."

Should have been fixed now.
This reverts commit 11e4cac84b69c323ab34ee9436d1be28de3788d2.

Files changed:
M .github/workflows/meta.yml
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-06-01T10:23:45+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@9957122

Configuring with plone/meta. Should fix the coverage job.

Files changed:
A news/e08b1234.internal
M .meta.toml
M tox.ini
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-06-01T10:31:23+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@42dbace

Merge pull request #120 from plone/config-with-default-template-4a127f9f

Improve help text for member fields option where fields are shown.

Files changed:
A .flake8
A .github/workflows/meta.yml
A news/3794.bugfix
A news/53dc5b4c.internal
A news/e08b1234.internal
M .editorconfig
M .gitignore
M .meta.toml
M .pre-commit-config.yaml
M plone/app/users/field_extender.py
M pyproject.toml
M tox.ini
D setup.cfg
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Jun 1, 2023
@mauritsvanrees
[fc] Repository: plone.app.users
fae63ce 
Branch: refs/heads/master
Date: 2023-05-31T10:03:59+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@d0d560d

Improve help text for member fields option where fields are shown.

For Managers the restriction to not show a field on the user profile does not apply.
Fixes plone/Products.CMFPlone#3794

Files changed:
A news/3794.bugfix
M plone/app/users/field_extender.py
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-05-31T10:04:28+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@e28521b

Configuring with plone/meta

Files changed:
A .flake8
A .github/workflows/meta.yml
A news/53dc5b4c.internal
M .editorconfig
M .gitignore
M .meta.toml
M .pre-commit-config.yaml
M pyproject.toml
M tox.ini
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-05-31T10:06:39+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@80540f8

chore: removed no longer needed setup.cfg.

Files changed:
D setup.cfg
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-05-31T10:18:04+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@e9d8592

chore: fix codespell config.

Files changed:
M .meta.toml
M pyproject.toml
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-05-31T10:18:14+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@00ea1af

Configuring with plone/meta

Temporarily ignore the Products.CMFPlone dependency.
See plone/plone.app.users#119

Files changed:
M .meta.toml
M pyproject.toml
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-05-31T10:29:32+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@11e4cac

Comment out circular workflow.

It always fails currently, because of a dependency cycle in three different packages.

Files changed:
M .github/workflows/meta.yml
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-06-01T10:22:38+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@2cd926e

Revert "Comment out circular workflow."

Should have been fixed now.
This reverts commit 11e4cac84b69c323ab34ee9436d1be28de3788d2.

Files changed:
M .github/workflows/meta.yml
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-06-01T10:23:45+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@9957122

Configuring with plone/meta. Should fix the coverage job.

Files changed:
A news/e08b1234.internal
M .meta.toml
M tox.ini
Repository: plone.app.users

Branch: refs/heads/master
Date: 2023-06-01T10:31:23+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.users@42dbace

Merge pull request #120 from plone/config-with-default-template-4a127f9f

Improve help text for member fields option where fields are shown.

Files changed:
A .flake8
A .github/workflows/meta.yml
A news/3794.bugfix
A news/53dc5b4c.internal
A news/e08b1234.internal
M .editorconfig
M .gitignore
M .meta.toml
M .pre-commit-config.yaml
M plone/app/users/field_extender.py
M pyproject.toml
M tox.ini
D setup.cfg
@jensens
Copy link
Member

jensens commented Jun 4, 2023

I would merge plone.app.users in Products.CMFPlone. There is no reason to keep it as a separate package.

@mauritsvanrees
Copy link
Member Author

I wanted to write that a merge would likely introduce cyclic imports. But a quick grep of Python code only shows plone.restapi importing from plone.app.users. I guess all code that needs to do something with a user is not calling plone.app.users directly, but all goes through acl_users.

@rber474 rber474 mentioned this issue Feb 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jensens @mauritsvanrees @gforcada