Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression for 404 #1673

Open
stevepiercy opened this issue Jun 21, 2024 · 5 comments
Open

Regression for 404 #1673

stevepiercy opened this issue Jun 21, 2024 · 5 comments
Assignees
Milestone

Comments

@stevepiercy
Copy link
Contributor

stevepiercy commented Jun 21, 2024

Description

See #1399

We want a default 404 to look like this:

https://6.docs.plone.org/404.html

Not like this:

https://6.docs.plone.org/whoopsie

Something regressed since this was deployed.

@polyester
Copy link
Member

Indeed a whoopsie. Custom 404 isn't properly set up in Ansible. Manually fixed for now, leaving issue open until I can fix that Ansible template.

@stevepiercy
Copy link
Contributor Author

Do you know when it regressed? I only noticed it because the 404 report in Matomo collected no data. I might have not set up the file correctly.

@fredvd does the 404 view require its own JavaScript snippet for Matomo to count it?

@polyester
Copy link
Member

polyester commented Jun 22, 2024

Yes, happened when I ran ansible to put in a new redirect. June 9th, 2024.

Mea Culpa <applies ash generously on head/>

@polyester
Copy link
Member

@stevepiercy as the server for 'static sites' holds quite a lot of those, it will require some planning to make sure that "custom 404 pages" will work without disrupting other sites, as the current setup pulls in a snippet for all sites on error pages. That needs re-working and a bit of planning. Will get on it.

@stevepiercy
Copy link
Contributor Author

Yes, happened when I ran ansible to put in a new redirect. June 9th, 2024.

That's much more recent than when we thought we configured Matomo and the documentation 404 template correctly. In fact, no 404 data has been collected ever. I think I have a fix for it, using a custom JavaScript snippet, but need to check with @fredvd.

@stevepiercy stevepiercy added this to the Plone 6.1 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants