Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Use Web Workers to Improve Lint All and Lint Folder Experience #337

Open
pjkaufman opened this issue Aug 6, 2022 · 1 comment · May be fixed by #1047
Open

FR: Use Web Workers to Improve Lint All and Lint Folder Experience #337

pjkaufman opened this issue Aug 6, 2022 · 1 comment · May be fixed by #1047
Assignees
@pjkaufman
Labels
code cleanup enhancement New feature or request obsidian Obsidian specific syntax issue or feature

Comments

@pjkaufman
Copy link
Collaborator

Currently when lint all is run, it runs asyncronously, which is fine so long as there are not a lot of files to parse. I have somewhere around 2k and it tends to lock up Obsidian when I run lint all to test out new rules. It would also be nice to have a persisted notice of the progress like what dataview does on load.

So the two requests are to offload linting to Web Workers where more than 1 is being linted at a time. The other is to allow the user to be aware of the amount of files found that will be linted versus the amount completed so far.
@pjkaufman pjkaufman added enhancement New feature or request obsidian Obsidian specific syntax issue or feature code cleanup labels Aug 6, 2022
@pjkaufman
Copy link
Collaborator Author

This will need to be done carefully with the addition of custom lint rules as they will need a way to identify which file is being worked on and by which worker since I cannot pass this info into custom lint commands. Likely that limits the amount of webworkers I can run.

@pjkaufman pjkaufman mentioned this issue Nov 9, 2022
Open
@pjkaufman pjkaufman mentioned this issue Nov 9, 2023
Open
2 tasks
@pjkaufman pjkaufman self-assigned this Dec 5, 2023
@pjkaufman pjkaufman mentioned this issue Dec 14, 2023
Closed
@pjkaufman pjkaufman linked a pull request Mar 16, 2024 that will close this issue
Draft
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjkaufman pjkaufman

Labels
code cleanup enhancement New feature or request obsidian Obsidian specific syntax issue or feature
Projects
Obsidian Linter
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Draft: Move Most Linting Logic to Web Workers pjkaufman/obsidian-linter
1 participant
@pjkaufman