Optimized RocksDBStore.IterateIndexes()
for pruned chain storage.
#4004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4003 for context.
Should follow #4001.This assumes a transition from a pruned storage to an unpruned storage is never allowed.
Together with #3999 and automatic pruning in
RocksDBStore()
constructor and further removal of chain id manipulating methods, the implementation should become much simpler.I haven't tested but I don't think
Iterator.SeekToPrev()
would be any faster. This is still slower than the original bugged implementation ofIterateIndexes()
, but the performance degradation is much more tolerable.