Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to rename the term “tx nonce” to “tx counter” #354

Open
dahlia opened this issue Jul 15, 2019 · 6 comments
Open

Suggest to rename the term “tx nonce” to “tx counter” #354

dahlia opened this issue Jul 15, 2019 · 6 comments
Labels
hacktoberfest Newcomer-welcoming issues for Hacktoberfest stale The issue is stale suggestion Suggestion or feature request

Comments

@dahlia
Copy link
Contributor

dahlia commented Jul 15, 2019

Currently every account has its own tx nonce and every time an account signs a new transaction a transaction has its nonce which matches to (1 + its signer's tx nonce) to avoid replay attack (see: #125). It has to be increased by only 1 so that a transaction's nonce refers to the number of how many prior transactions were signed by the same signer. The problem is that it's no more random nor arbitrary, which is counterintuitive to many people presume on the concept of cryptographic nonce.

So I suggest to rename it to tx counter instead. Request for comments.

@dahlia dahlia added the suggestion Suggestion or feature request label Jul 15, 2019
@baumstern
Copy link
Contributor

+1.

It seems to me that the term nonce is used generally in some cases like stateless protocol (i.e. user authentification). Arbitrary value in temporary would just enough to achieve uniqueness of message in this context. Using this term in stateful account model may confuse people because replay attack is prevented by order of transaction rather than arbitrary value.

@stale
Copy link

stale bot commented Oct 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale The issue is stale label Oct 30, 2019
@stale stale bot closed this as completed Nov 6, 2019
@limebell limebell reopened this Nov 7, 2019
@stale stale bot removed the stale The issue is stale label Nov 7, 2019
@stale
Copy link

stale bot commented Jan 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale The issue is stale label Jan 6, 2020
@dahlia dahlia removed the stale The issue is stale label May 20, 2020
@stale
Copy link

stale bot commented Jul 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale The issue is stale label Jul 19, 2020
@riemannulus riemannulus added hacktoberfest Newcomer-welcoming issues for Hacktoberfest and removed stale The issue is stale labels Sep 22, 2020
@stale
Copy link

stale bot commented Nov 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale The issue is stale label Nov 21, 2020
@OnedgeLee
Copy link
Contributor

OnedgeLee commented Oct 25, 2024

Has this issue been discussed?
Seems a bit weird, hacktoberfest label is attached, it's only suggestion though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Newcomer-welcoming issues for Hacktoberfest stale The issue is stale suggestion Suggestion or feature request
Projects
None yet
Development

No branches or pull requests

5 participants