Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make subgraph instead of using partial class for ActionQuery #1849

Open
U-lis opened this issue Jan 26, 2023 · 0 comments
Open

Make subgraph instead of using partial class for ActionQuery #1849

U-lis opened this issue Jan 26, 2023 · 0 comments
Labels
api/graphql help wanted Extra attention is needed

Comments

@U-lis
Copy link
Contributor

U-lis commented Jan 26, 2023

          Frankly, I'm not a big fan of `partial` class since usually it can be a signal of abstraction lacking. (i.e., if we need to `partial` to maintain some class, It can also mean that the class has too many features)

it might be better to consider subgraphs, even if on the next PR. 🤔

Originally posted by @longfin in #1837 (comment)

@U-lis U-lis added help wanted Extra attention is needed api/graphql labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api/graphql help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant