Use best available JWS alg for identity token fetch #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaol
force-pushed
the
feature/negotiate-JWS-alg
branch
from
2818748 to
ab42273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, openid-connect is not using the
id_token_signing_alg_values_supporteddata from the discovery document and only relies on JOSE'sbestJWSAlgto select a signing algorithm to use. There's no guarantee that the recipient will recognize the signed token if it's using something out of the discovery document's advertised values.This branch uses
negotiateJWSAlgand thealg_values_supportedlist from the discovery document. This is a feature that's not yet in a released version of JOSE so the function may yet be subject to change. See frasertweedale/hs-jose#118