Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1194: Endpoint::Options::backlog_ not used #1195

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

jiankyu
Copy link
Contributor

@jiankyu jiankyu commented Feb 24, 2024

This commit passes down the Options::backlog_ in the following invocation: Http::Endpoint::init() -> Tcp::Listener::init()

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.11%. Comparing base (1964b0c) to head (80ca76d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1195      +/-   ##
==========================================
+ Coverage   78.08%   78.11%   +0.02%     
==========================================
  Files          53       53              
  Lines        7077     7077              
==========================================
+ Hits         5526     5528       +2     
+ Misses       1551     1549       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiplingw
Copy link
Member

Thanks @jiankyu. You'll need to update the versioning too. Otherwise it looks good.

This commit passes down the Options::backlog_ in the following invocation:
Http::Endpoint::init() -> Tcp::Listener::init()
@jiankyu
Copy link
Contributor Author

jiankyu commented Feb 24, 2024

Thanks @kiplingw for pointing this out. Updated the version, in my time zone it's Feb 23, hope it doesn't make a big deal.

@kiplingw
Copy link
Member

LGTM. @Tachi107, if you're fine with it feel free to merge.

Copy link
Member

@Tachi107 Tachi107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too, thanks for the fix!

@Tachi107 Tachi107 merged commit 875c973 into pistacheio:master Feb 24, 2024
26 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants