-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve fuzzer #1191
Improve fuzzer #1191
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1191 +/- ##
==========================================
- Coverage 78.09% 78.09% -0.01%
==========================================
Files 53 53
Lines 7082 7077 -5
==========================================
- Hits 5531 5527 -4
+ Misses 1551 1550 -1 ☔ View full report in Codecov by Sentry. |
8103d0f
to
aceac31
Compare
Good work @tyler92. We'll get back to you as soon as we've had a chance to review. |
Hi @tyler92, thanks for the patch! Fuzzing is definitely an interesting area where we could do better.
What you can do instead is add a
|
aceac31
to
1076405
Compare
97bf943
to
5dba79a
Compare
@Tachi107 Thanks for the hint with |
@kiplingw Just in case - there are no more changes expected on my part, the MR is ready for review. Please let me know if something has to be fixed or improved. |
The current fuzzer target covered only basic things and didn't cover the most interesting parts of HTTP request parsing. I've extended fuzzer with more targets and added a corpus. As a result, coverage has been increased significantly and several memory issues have been found; I will report them separately to avoid mixing them with this MR.
Notes: