Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to construct CNAME packets #22

Open
2 tasks
maxhawkins opened this issue Apr 4, 2019 · 0 comments
Open
2 tasks

Make it easier to construct CNAME packets #22

maxhawkins opened this issue Apr 4, 2019 · 0 comments

Comments

@maxhawkins
Copy link
Contributor

maxhawkins commented Apr 4, 2019

Summary

Add helper functions to make it easier to construct SourceDescription CNAME packets.

  • Make easier to use constructor for SourceDescriptions
  • Add helpers for choosing RFC 7022 CNAMEs

Motivation

Currently it's cumbersome to generate CNAME packets:

cname := &SourceDescription{
	Chunks: []SourceDescriptionChunk{{
		Source: 1234,
		Items: []SourceDescriptionItem{{
			Type: SDESCNAME,
			Text: "cname",
		}},
	}},
}

Because every CompoundPacket requires a SourceDescription with a CNAME, we should make creating these packets easy.

kevmo314 added a commit that referenced this issue Nov 19, 2021
This specific source description is very common. This change introduces
a helper method to simplify the creation of CNAME source descriptions.

#22
kevmo314 added a commit that referenced this issue Nov 19, 2021
This specific source description is very common. This change introduces
a helper method to simplify the creation of CNAME source descriptions.

#22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant