Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch file instead of polling #5

Open
xmedeko opened this issue Apr 12, 2021 · 1 comment
Open

Watch file instead of polling #5

xmedeko opened this issue Apr 12, 2021 · 1 comment

Comments

@xmedeko
Copy link

xmedeko commented Apr 12, 2021

What about to use file watcher chokidar instead of poll interval?

@jsumners
Copy link
Member

That would significantly increase the dependency tree. In fact, at this point, the dependency tree could be zero with a PR to remove fast-json-parse.

The readme for that chokidar module says that it will use a native extension for macOS, but continue to use fs.watchFile on other platforms. I'm a hard "no" on adding a native extension. I could probably be convinced to add a watcher option if it is based solely on the core fs.watch API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants