Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CannotInsertFlag to indicate that this table cannot be inserted #1133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add CannotInsertFlag to indicate that this table cannot be inserted #1133

wants to merge 1 commit into from

Conversation

7yyo
Copy link

@7yyo 7yyo commented Dec 19, 2020

What problem does this PR solve?

Include no_zero_date in sqlmode, these scenarios should fail to add column:

create table t (id int);
insert into t values(1);
alter table t add column a date not null;
alter table t add column a date not null;

Considering that data may be written during the DDL state change phase, need a flag to prevent data insert during this period. So add this table level flag.

What is changed and how it works?

Check List

Tests

  • No code

Code changes

  • Has exported variable/fields change

Side effects

Related changes

@7yyo
Copy link
Author

7yyo commented Dec 19, 2020

@bb7133 PTAL

@7yyo 7yyo marked this pull request as draft January 16, 2021 15:06
@7yyo 7yyo marked this pull request as ready for review January 16, 2021 15:07
@ti-chi-bot
Copy link
Member

@7yyo: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants