Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecommerce filter interpreter at the attribut level #82

Open
Yivan opened this issue Jul 27, 2020 · 1 comment
Open

Ecommerce filter interpreter at the attribut level #82

Yivan opened this issue Jul 27, 2020 · 1 comment

Comments

@Yivan
Copy link
Contributor

Yivan commented Jul 27, 2020

Hello,

This issue propose to add a filter interpreter parameter in e-commerce yaml config to associate to an attribut, some thing like:

    myAttribut:
        type: varchar(190)
        filter_group: string
        filter_interpreter: Path\To\MyInterpreterClass     <= this is the new setting proposed in this issue

The pupose of this interpreter will be to be able to customize the displaying filters values for this attribut.
Sometimes we want to index in store database some values (let's say an ID for instance) but for the filters we want to get the object and display a specific fields or data reformated during filter html generation, aka to set label to custom values, etc.

I think it could be a valuable tool. Actually we need to check the type of attribut and modifying the labels directly in custom filter-select.html file for instance finishing in hard to maintain code because having all the labels logics in the filter html file.

Having the possibility to define a filter interpreter directly at the attribut level would be more clean and reusable (instead to patch all filters which could be using this attribut for instance, it will be only needed to set a filter_interpreter at the attribut level).

Best regards.

@stale
Copy link

stale bot commented Mar 14, 2022

Thanks a lot for reporting the issue. The issue was not considered by us as "Priority" or "Backlog", so we're not gonna work on that anytime soon. In case this is a bug report, please create a pull request fixing the issue, we'll then review it as soon as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request, we'll then decide whether we'd accept it or not. Thanks for your understanding.

@stale stale bot added the PR Welcome label Mar 14, 2022
@brusch brusch changed the title New feature - Ecommerce filter interpreter at the attribut level Ecommerce filter interpreter at the attribut level May 31, 2023
@brusch brusch transferred this issue from pimcore/pimcore May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant