Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cannot use a custom TrackingManager #178

Open
mlumia opened this issue Apr 17, 2024 · 1 comment
Open

[Bug]: Cannot use a custom TrackingManager #178

mlumia opened this issue Apr 17, 2024 · 1 comment

Comments

@mlumia
Copy link

mlumia commented Apr 17, 2024

Expected behavior

Setting a custom Tracking Manager in the config tracking_manager_id should output the tracked codes for the active GoogleTagManager tracker.

The event subscriber TrackingCodeFlashMessageListener should move the flash message tracked codes to the Tracker tracked codes.

The event subscriber TrackingCodeSubscriber should prepend the tracked codes to the GoogleTagManagerEvents event block.


Info: The use of the Factory is required to get the TrackingManager. Using DI is incorrect. The documentation example also show the use of DI as the "method" to implement, which is incorrect.

Actual behavior

Both EventSubscribers (TrackingCodeSubscriber and TrackingCodeFlashMessageListener) use DI to get the TrackingManager which is not loaded with the $trackers from the compiler pass.

The tracked codes by the tracking_manager_id TrackingManager is not output.

Steps to reproduce

  1. Create a custom TrackingManager class
  2. Set the tracking_manager_id as the custom TrackingManager class
pimcore_ecommerce_framework:
    tracking_manager:
        tracking_manager_id: App\Tracking\MyCustomerTrackingManager
        trackers:
            tag_manager:
                id: Pimcore\Bundle\EcommerceFrameworkBundle\Tracking\Tracker\GoogleTagManager
                enabled: true
  1. Track a product view in a controller:
    $this->factory->getTrackingManager()->trackProductView($product);
  2. Optional to test forwardTrackedCodesAsFlashMessage():
    $this->factory->getTrackingManager()->forwardTrackedCodesAsFlashMessage();
  3. Check HTML output for: dataLayer.push which is not output.
@mlumia mlumia added the Bug label Apr 17, 2024
@mlumia mlumia changed the title [Bug]: Cannot set a custom TrackingManager in config tracking_manager_id [Bug]: Cannot use a custom TrackingManager Apr 17, 2024
Copy link

github-actions bot commented May 8, 2024

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant