Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split get_relative_mass_balance #22

Open
JakobBD opened this issue Aug 23, 2024 · 1 comment
Open

split get_relative_mass_balance #22

JakobBD opened this issue Aug 23, 2024 · 1 comment

Comments

@JakobBD
Copy link
Collaborator

JakobBD commented Aug 23, 2024

The "total" shouldn't be in this function.
Instead, there should be a function calling get_mass_balance and dividing it by a total.
@JakobBD
Copy link
Collaborator Author

JakobBD commented Sep 17, 2024

Further:

  • check_mass_balance could be moved outside MFASystem (a helper function for example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JakobBD