Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with loop in 0.13.2 #223

Open
Czajnikowski opened this issue Dec 3, 2019 · 4 comments
Open

Problem with loop in 0.13.2 #223

Czajnikowski opened this issue Dec 3, 2019 · 4 comments
Labels

Comments

@Czajnikowski
Copy link

Currently if I set up Player like:

let player = Player()
player.playbackLoops = true

And then set the local URL + play() on it I'm getting it played only once. I checked what PlayerPlaybackDelegate reports and it reports a couple of playerCurrentTimeDidChanges and then playerPlaybackDidEnd.

Do we have a regression? It was (and still) works fine in 0.13.1

@piemonte
Copy link
Owner

piemonte commented Dec 4, 2019

hey @Czajnikowski seems like this commit is the only thing that could be causing this.

d67e7d7

will revert it from master. could you let me know if it works OK for you?

@Czajnikowski
Copy link
Author

Hey @piemonte , thanks for your prompt reply 🙂

I have given it a try on my local clone and reverting it doesn't seem to do the trick.

@yueno12
Copy link

yueno12 commented Dec 19, 2019

+1

@piemonte piemonte added the bug label Jan 7, 2020
@paulocoutinhox
Copy link

Hi. It was solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants